D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Albert Astals Cid]

aacid added a comment.


  In D20005#437053 <https://phabricator.kde.org/D20005#437053>, @cgiboudeaux wrote:
  
  > In D20005#437052 <https://phabricator.kde.org/D20005#437052>, @aacid wrote:
  >
  > > > Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.
  > >
  > > Does it? it doesn't here, or you mean "requires Qt5Widgets" because it tries to use Qt5::uic ?
  >
  >
  > Qt5::uic is defined in Qt5WidgetsConfigExtras.cmake
  
  
  Yes, but Qt5::uic  is only used if you call KI18N_WRAP_UI, if you call KI18N_WRAP_UI is because you have .ui files in your project, if you have .ui files in your project, your project should be depending on Qt5Widgets, if it's not, it's a bug because you are directly using Qt5Widgets, so just add it there.
  
  Making ki18n depend on Qt5Widgets unconditionally because a function that you may call if you use Qt5Widgets needs Qt5Widgets doesn't seem the best of the ideas to me, there's valid use cases for ki18n to not use Qt5Widgets and in those cases it'll never go thorough KI18N_WRAP_UI, so it will just work.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: cgiboudeaux, aacid, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190324/fffd5d26/attachment.html>