D19979: Don't create thumbnails for encrypted Vaults

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Mar 23 12:05:50 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> previewjob.cpp:307
>  
> +    auto mountsList = KMountPoint::currentMountPoints();
> +    KMountPoint::List encryptedMountsList;

Did you profile the impact of this call? I don't think it's cached. Can this maybe be moved to the thumbnail KIO so it's done out of process?

> previewjob.cpp:325
> +
> +        if (encryptedMountsList.findByPath(item.item.url().toLocalFile())) {
> +            continue;

Use `KFileItem::localPath()`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190323/a5ab617e/attachment.html>


More information about the Kde-frameworks-devel mailing list