D19445: Handle variant list in formatting functions

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> propertyinfo.cpp:634
> +        if (d->valueType == QVariant::StringList || d->valueType == QVariant::String ) {
> +            return FormatStrings::joinStringListFunction(value);
> +        } else {

Don't reinvent Qt functionality:
https://doc.qt.io/qt-5/qlocale.html#createSeparatedList

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19445

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190322/b4745416/attachment.html>