D19967: [kpeople] make it compile without foreach

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Mar 22 13:26:28 GMT 2019


apol added inline comments.

INLINE COMMENTS

> matchessolver.cpp:63
> +            QList<QString>::const_iterator it = destinationResolver.keys(urlB).constBegin();
> +            const QList<QString>::const_iterator end = destinationResolver.keys(urlB).constEnd();
> +            for (; it != end; ++it) {

You are calling destinationResolver.keys(urlB) twice here.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D19967

To: mlaurent, dfaure
Cc: apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190322/e78b694d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list