D19812: Add a web page to view and compare icons of different sizes

Pino Toscano noreply at phabricator.kde.org
Fri Mar 22 08:46:23 GMT 2019


pino added a comment.


  Few notes on the new `generate_web_data.sh` script:
  
  - please quote the paths properly, otherwise it will break when either the source directory or the build directory contain e.g. spaces
  - it does not seem using any bash-specific features, so make it using `/bin/sh`, to help non-Linux Unices (where usually bash is not available by default, and/or not in `/bin`)
  - please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty string (to prevent typos)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190322/83efa915/attachment.html>


More information about the Kde-frameworks-devel mailing list