D19939: Avoid failing installation via temporary dir due to file name clashes

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So the solution would be to cache the calculated result. Which would also allow to have this as flag for some proper post-install cleanup once that is sorted out and defined.
  
  Problem is: `KNSCore::Installation` is an exported class, with an installed header. So it would need to stay binary compatible.
  Unless we give the comment "@internal" in the class documentation more emphasis. Not sure though if people have been aware of that, given the resulting API dox page does not carry that information bit: https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1Installation.html
  
  Now does the class not have a pimpl implementation, so we could simply add another data item.
  Another option would be to reuse the existing set of directory/path members for the different installation dir types, where only one of is used. By the cost of a bit more fragile logic due to the abuse, but what else could be done?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19939

To: kossebau, #frameworks, leinir, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190321/a7231745/attachment-0001.html>