D19551: [knotifications] compile without foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> mlaurent wrote in knotifyconfig.cpp:53
> How we can use iterator here ?
> I didn't find a method for it.

Urgh, indeed. What kind of container is that....
Never mind then....

> notifybypopup.cpp:426
> +        emit finished(i.key());
> +        ++i;
>      }

This is why a for() loop is better than a while loop() for such usage.

REPOSITORY
  R289 KNotifications

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19551

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190320/eb54afbe/attachment.html>