D19551: [knotifications] compile without foreach

Pino Toscano noreply at phabricator.kde.org
Wed Mar 20 07:43:21 GMT 2019


pino added inline comments.

INLINE COMMENTS

> notifybypopup.cpp:424
> +    QMap<KNotification*, KPassivePopup *>::const_iterator i = d->passivePopups.constBegin();
> +    while (i != d->passivePopups.constEnd()) {
> +        emit finished(i.key());

this loop now will run forever...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19551

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190320/174fbbbb/attachment.html>


More information about the Kde-frameworks-devel mailing list