D19858: Handle unsupported OCS commands, and don't over-vote
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Mon Mar 18 15:40:03 GMT 2019
leinir added a comment.
In D19858#433788 <https://phabricator.kde.org/D19858#433788>, @ngraham wrote:
> Thanks! Makes sense, and fixes the bug. :)
>
> Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.
Yeah, first step being to not make things look critically broken is good, and then we can work out the larger thing of making it behave pleasantly and disallow voting for servers which don't, well, allow it :)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D19858
To: leinir, #knewstuff, ronaldv, ngraham
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190318/e8f466b9/attachment.html>
More information about the Kde-frameworks-devel
mailing list