D19858: Handle unsupported OCS commands, and don't over-vote

Nathaniel Graham noreply at phabricator.kde.org
Mon Mar 18 15:29:20 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> itemsviewdelegate.cpp:287
>              rating->setRating((entry.rating() - 20) * 10 / 60);
> +            rating->blockSignals(true);
>              // put the rating label below the install button

Why do we need to do this twice?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19858

To: leinir, #knewstuff, ronaldv, ngraham
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190318/289e7812/attachment.html>


More information about the Kde-frameworks-devel mailing list