D19828: [Kinit] Compile without foreach

Pino Toscano noreply at phabricator.kde.org
Mon Mar 18 07:42:35 GMT 2019


pino added inline comments.

INLINE COMMENTS

> kinit_win.cpp:301-303
> +    for (const ProcessListEntry *ple : qAsConst(m_processes)) {
>          delete ple;
>      }

qDeleteAll?

> kinit_win.cpp:454
> +    const auto list = processList.list();
> +    for (const ProcessListEntry *ple : lst) {
>          if (!ple->path.isEmpty() && ple->path.toLower().startsWith(installPrefix.toLower())) {

'lst' vs 'list'

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D19828

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190318/0b60457a/attachment.html>


More information about the Kde-frameworks-devel mailing list