D19491: generic config interface
Dominik Haumann
noreply at phabricator.kde.org
Sun Mar 17 08:21:58 GMT 2019
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
I see two possible performance issues:
1. Using std::map. ...but the size() is small.
2. See comment.
But that needs profiling later.
Please push.
INLINE COMMENTS
> kateconfig.cpp:124
> + const auto knownIt = knownEntries.find(key);
> + Q_ASSERT(knownIt != knownEntries.end());
> +
Possible performance issue? We'll see later.
REPOSITORY
R39 KTextEditor
BRANCH
arcpatch-D19491_1
REVISION DETAIL
https://phabricator.kde.org/D19491
To: cullmann, #ktexteditor, dhaumann, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190317/ee2f0680/attachment.html>
More information about the Kde-frameworks-devel
mailing list