D19750: [attica] compile without foreach

[David Faure]

dfaure added a comment.


  Everything else looks OK.

INLINE COMMENTS

> providermanager.cpp:106
>  {
> -    foreach (const QUrl &url, d->m_internals->getDefaultProviderFiles()) {
> +    const auto lstProvider = d->m_internals->getDefaultProviderFiles();
> +    for (const QUrl &url : lstProvider) {

the variable could be better named, like providerFiles or just files
(these are files, not providers)

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19750

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190316/3a455b0b/attachment.html>