D19812: Add a web page to view and compare icons of different sizes
Yunhe Guo
noreply at phabricator.kde.org
Sat Mar 16 22:57:28 GMT 2019
guoyunhe added a comment.
In D19812#432326 <https://phabricator.kde.org/D19812#432326>, @ngraham wrote:
> Neato! Looks pretty handy. Two issues I found:
>
> - generate_web_data.sh isn't executable
> - I'd like to see this run as part of the build process, so that `index.html` gets updated automatically, and so running it doesn't pollute your source folder since you're of course doing out-of-source builds :) Then you don't have to add the generated text files to .gitignore.
Hi @ngraham , I have added execution bit to the script. I have too little knowledge of CMake. Not sure if this will do what you said. Can you give some hints?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D19812
To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190316/3eed46dd/attachment.html>
More information about the Kde-frameworks-devel
mailing list