D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Mar 16 06:18:46 GMT 2019


kossebau updated this revision to Diff 53986.
kossebau added a comment.


  Only prevent width/height of textureRect becoming 0, otherwise keep old
  behaviour. Not changing to qround to prevent bad image quality due to
  up-sampling.
  
  F6695867: Screenshot_20190316_070411.png <https://phabricator.kde.org/F6695867>
  
  I learned that CSS3 also has a concept of doing frames from images. And
  there are quite some options for doing the tiling of the border image, seems
  Plasma currently implements the "stretch" and "round" options:
  https://www.w3.org/TR/css-backgrounds-3/#the-border-image-repeat
  
  Perhaps some direction to extend the Plasma theme spec to in the future.
  HiDpi might allow theme authors to do more fancy themes where then more
  control about might be good to have -> setting a thought seed into whoever will work
  on that :P

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19787?vs=53958&id=53986

BRANCH
  fixtilingtexture

REVISION DETAIL
  https://phabricator.kde.org/D19787

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma, mart
Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190316/ea2c3686/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list