D19784: Avoid calling QT_LSTAT and accessing recent documents

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:254
> +    // return any useful information for our purposes here.
> +    url.setScheme(QString());
> +    KFileItem fileItem(url);

This looks very much like a workaround. How about adding an argument to the KFileItem to skip the stat if it's a desirable behaviour?

> recentusagemodel.cpp:277
> +        // We want MatchMode mode = MatchExtension
> +        if (url.scheme() == "file") {
> +            url.setScheme(QString());

url.isLocalFile()

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190315/63ff0c65/attachment-0001.html>