D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Mar 15 18:40:36 GMT 2019


apol added a comment.


  Does this solve the fluffy bunny issue?
  Otherwise it could be that the theme needs adapting to tell plasma to repeat the pattern instead of stretching it.

INLINE COMMENTS

> framesvgitem.cpp:148
>              if (m_border == FrameSvg::TopBorder || m_border == FrameSvg::BottomBorder || m_border == FrameSvg::NoBorder) {
> -                textureRect.setWidth(nodeRect.width() / m_elementNativeSize.width());
> +                textureRect.setWidth((qreal)nodeRect.width() / m_elementNativeSize.width());
>              }

Makes sense to me. Should we also use qRound?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19787

To: kossebau, #plasma, mart
Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190315/7c2980f1/attachment.html>


More information about the Kde-frameworks-devel mailing list