D19783: [kitemview] compile without foreach

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Mar 15 18:32:55 GMT 2019


apol added inline comments.

INLINE COMMENTS

> kwidgetitemdelegatepool.cpp:136
> +    const auto lst = d->widgetInIndex.keys();
> +    for (QWidget *widget : lst) {
>          const QAbstractProxyModel *proxyModel = qobject_cast<const QAbstractProxyModel *>(d->delegate->d->model);

This one clearly should be using iterators instead of foreach

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D19783

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190315/805f72ee/attachment.html>


More information about the Kde-frameworks-devel mailing list