D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Fri Mar 15 14:37:56 GMT 2019
kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
The old logic results in broken rendering if the sample was bigger than the
area to render, due to normalized texture rect being 0 in the respective
dimansion. As well as stretched mapping of the sample for fractional
relationships between the area to render and the sample size.
TEST PLAN
Borders of backgrounds of FluffyBunny theme render properly, no other
regressions seen (but unsure what else might rely on that artifact).
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
fixtilingtexture
REVISION DETAIL
https://phabricator.kde.org/D19787
AFFECTED FILES
src/declarativeimports/core/framesvgitem.cpp
To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190315/a2131586/attachment.html>
More information about the Kde-frameworks-devel
mailing list