D19696: Add blender thumbnailer

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Mar 15 00:45:04 GMT 2019


bruns added a comment.


  Save the two nitpicks, looks good to me now.
  
  Anyone else any comments?

INLINE COMMENTS

> blendercreator.cpp:24
> +#include <assert.h>
> +#include <zlib.h>
> +

Really required?

> blendercreator.cpp:29
> +#include <QPointer>
> +#include <QDebug>
> +#include <QtEndian>

Unused ...

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190315/e8104d85/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list