D19728: [GridViewKCM] Fix implicit width calculation

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Mar 13 14:50:39 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Take into account paddings around the page and scroll view and also use the correct grid delegate size

TEST PLAN
  Opened colors KCM, size was correct to the pixel now. Resized the window smaller a single pixel and it wrapped the delegates into two columns
  Initial size before
  F6688642: Screenshot_20190313_154950.png <https://phabricator.kde.org/F6688642>
  Initial size after
  F6688643: Screenshot_20190313_155027.png <https://phabricator.kde.org/F6688643>

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19728

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190313/6e93d212/attachment.html>


More information about the Kde-frameworks-devel mailing list