D19686: don't scale when we are in AA_UseHighDpiPixmaps

Marco Martin noreply at phabricator.kde.org
Mon Mar 11 15:44:41 GMT 2019


mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  when the flag AA_UseHighDpiPixmaps is set, the pixmap is already scaled,
  no need to scale it twice.
  the code calling virtual_hook in QIcon calls it with the following
  ScaledPixmapArgument:
  scalePixmapArg = { size * devicePixelRatio, mode, state, devicePixelRatio, QPixmap() }
  The requested pixmap size is already scaled, counting devicePixelRatio
  again will result in a pixmap scaled two times.

TEST PLAN
  Icons in apps with fractional scaling look a lot better

REPOSITORY
  R302 KIconThemes

BRANCH
  phab/iconRendering

REVISION DETAIL
  https://phabricator.kde.org/D19686

AFFECTED FILES
  src/kiconengine.cpp

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190311/5ffb8e89/attachment.html>


More information about the Kde-frameworks-devel mailing list