D19674: [Icon Item] Also clear image icon when using Plasma Svg
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Mar 11 08:48:44 GMT 2019
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
When changing an `IconItem` from using a local image (e.g. PNG file) to using a Plasma themed icon, the implicit size wasn't updated since the old image was still loaded in `m_imageIcon`. Clearing it when clearing the other icon stores fixes this.
BUG: 405298
TEST PLAN
- Changed kickoff icon to be a rectangular image, reset it back to default, button size updated correctly
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D19674
AFFECTED FILES
src/declarativeimports/core/iconitem.cpp
To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190311/ca6677b7/attachment.html>
More information about the Kde-frameworks-devel
mailing list