D16579: Remove support for non-standard APE tag field names from the test files

[Matthieu Gallien]

mgallien added a comment.


  In D16579#428835 <https://phabricator.kde.org/D16579#428835>, @smithjd wrote:
  
  > The change was ack'ed in this review, and this review closed by the commit.
  >
  > There was no code that required further review, only binary changes. The posted concerns were addressed by D18826 <https://phabricator.kde.org/D18826>.
  >
  > If you really are that concerned that this review is cleaned up, request yourself that the reviewers that requested changes clear their request. I don't need to ask them to when the request is no longer valid. Otherwise, please at least read the full review closely before complaining about events you weren't consulted on or involved with, and have imo little reason to force a re-visit of.
  
  
  Hello, the tone of your comment is not appropriate.
  
  Please avoid this.
  
  I agree with @ngraham, you should have asked both commenters if they were in agreement with the content and scope of the review before landing it. This is the way reviews work.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: ngraham, bruns, astippich, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190311/086e99a0/attachment.html>