D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar added a comment.


  > Just to be on the safe side: Does this also work, if you have two views visible showing the same document, and then the message appears?
  
  As said, poor tested., but what needs to be taken care? Normally these messages works well, so no idea why now not.
  
  > Does it also work, if you have two main windows showing the same document (View > New Window)?
  
  Do you mean something else than this hint?
  
  > One issue may/is that in case of multible views/windows the actions only get synced after an reload event :-/
  
  A tip how to solve this may helpful.

INLINE COMMENTS

> dhaumann wrote in kateview.cpp:238-239
> Could you use new-style signal/slot syntax for new code? :)

Yeah, normally I do. Here I was not sure if it will keeped/accepted and only did lazy copy old code :-)

BTW I'm surprised that such function (slot) didn't alrady exist. Instead will in the doc all views at some points directly called to update some things. See e.g. DocumentPrivate::documentReload:4310

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190311/5fd96d64/attachment-0001.html>