D19655: [kfilemetadata] Make it compile without foreach

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> externalextractor.cpp:151
> +    const auto lstKeys = propertiesObject.keys();
> +    for (const auto &key : lstKeys) {
>          if (key == QStringLiteral("typeInfo")) {

Can you change this to iterate over the entries, without intermediate list?

> externalwriter.cpp:112
>  
> -    Q_FOREACH(const Property::Property &property, propertiesKeys) {
> +    for (const Property::Property &property : propertiesKeys) {
>          PropertyInfo propertyInfo(property);

dito, iteration without intermediate list.

> taglibextractor.cpp:928
>              result->add(Property::Location, loc);
>          }
>  

The changes in taglibextractor are no longer necessary after D18826 <https://phabricator.kde.org/D18826> has landed, you can omit these.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19655

To: mlaurent, dfaure
Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190310/327a2a88/attachment-0001.html>