D19633: Improve consistency of window-* and add more

[Nathaniel Graham]

ngraham added a comment.


  In D19633#427965 <https://phabricator.kde.org/D19633#427965>, @ndavis wrote:
  
  > In D19633#427913 <https://phabricator.kde.org/D19633#427913>, @ngraham wrote:
  >
  > > Neat! Very helpful, thanks.
  > >
  > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195
  >
  >
  > Yes, but I'm not sure if it should copy the style of the unpin button from the tilebar or if it should have a line through it like you suggested. I feel like the line is more clear, but less consistent. Maybe it's the titlebar button unpin that should be changed?
  
  
  Yeah, I kinda think the titlebar icon should look more like a toggle action such that a pinned window just gets a background circle and the symbol inverts. Regardless, we'd need a different style anyway for the proposed `window-unpin` icon since it's going to be used for a menu action where the title literally is "Unpin from Task Manager."

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190310/76da6b05/attachment.html>