D18915: Fix batchrename changing extension to lower case
Christoph Feck
noreply at phabricator.kde.org
Fri Mar 8 20:53:26 GMT 2019
cfeck added inline comments.
INLINE COMMENTS
> cfeck wrote in batchrenamejob.cpp:165
> Function/method names are usually lowercase. Also, we don't add `get` for getters, only `set` for setters.
>
> ⇒ `fileExtension()` ?
>
> Additionally, we pass QString via reference
>
> ⇒ `QString &filename` ?
Actually, const reference:
`const QString &filename`
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18915
To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190308/9c4e500c/attachment.html>
More information about the Kde-frameworks-devel
mailing list