D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> taglibextractor.cpp:364
> +    lstASF = asfTags->attribute("Author");
> +    QStringList authors;
>      for (const auto& attribute : qAsConst(lstASF)) {

This intermediate list is not required, you can directly call result->add() for each attribute in lstASF.

> taglibextractor.cpp:376
>      lstASF = asfTags->attribute("WM/Writer");
> +    QStringList lyricists;
>      for (const auto& attribute : qAsConst(lstASF)) {

This intermediate list is not required, you can directly call `result->add()` for each attribute in lstASF.

> taglibextractor.cpp:392
> +    if (!lstASF.isEmpty()) {
> +        const auto attribute = lstASF.front();
> +        result->add(Property::Publisher, TStringToQString(attribute.toString()).trimmed());

Why only the first element?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190308/bf1971b5/attachment.html>