D19608: [WIP] DocumentPrivate: Make bracket handling smart

loh tar noreply at phabricator.kde.org
Fri Mar 8 10:16:11 GMT 2019


loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann, mwolff.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This patch checks if the entered closing bracket is already balanced and
  skip the input in this case. Targets the "nested autbracket" problem 
  without to base on this enabled config setting.

TEST PLAN
  - Will substitude D12295 <https://phabricator.kde.org/D12295>
  - Perhaps could D19598 <https://phabricator.kde.org/D19598> also catched here when findMatchingBracket will be modified?
  - Some autotests are failing now
  
    24 - kateindenttest_testCppstyle (Failed)
    25 - kateindenttest_testCMake (Failed)
    48 - movingrange_test (Failed)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19608

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190308/bca5bf90/attachment.html>


More information about the Kde-frameworks-devel mailing list