D19599: textfield height based only on clear text

Nathaniel Graham noreply at phabricator.kde.org
Thu Mar 7 17:48:20 GMT 2019


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  It's fixed!!!!
  
  Of course now the issue with the dots is worse since the dots are just too high up in the text field: F6670642: Peek 2019-03-07 10-44.gif <https://phabricator.kde.org/F6670642>
  
  However that's an issue in Noto Symbols itself. Aoparently all the characters in the whole font have a descent value that's too large (7 vs 4 for in regular Noto Sans). We're tracking this with https://github.com/googlei18n/noto-fonts/issues/1468. Thanks so much for fixing this, Marco!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/echo

REVISION DETAIL
  https://phabricator.kde.org/D19599

To: mart, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190307/2fbcbf4a/attachment.html>


More information about the Kde-frameworks-devel mailing list