D19598: DocumentPrivate: Make auto bracket slightly smarter

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ..in handling of quotes
  
  - Skip auto quotes when these looks already balanced
  - Improve readability, const correctness
  - const QChar as value, not reference
  
  BUG:405089
  FIXED-IN: 5.56

TEST PLAN
    Try to type this in a C++ file:
    ('\'') => ended up in something like: ('\''')
    
    Try to add afterwarnds double quotes to some word in a text, without to select the word:
    foo "bar" haz => ended up in something like: foo "bar"" haz
  
  - Autotest looks good
  - Contains partial code from unloved D17693 <https://phabricator.kde.org/D17693> which is here only added to became it in. See latter two Summary notes
  - Is the fix-in number right?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19598

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190307/2dd32f2b/attachment.html>