D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Mar 7 10:15:49 GMT 2019


broulik created this revision.
broulik added reviewers: dfaure, chingku.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a file already exists and user choses to rename the file, the URL wasn't updated.
  This lead to the job potentially still showing the old destination when finished.

TEST PLAN
  See D19585 <https://phabricator.kde.org/D19585>
  
  Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it sit at the "Override?" prompt until the job view in Plasma showed up. Chose a different filename and continued.
  
  With this, the destination URL reflects the rename and points to the actual file copied.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19586

AFFECTED FILES
  src/core/copyjob.cpp

To: broulik, dfaure, chingku
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190307/52b6bc91/attachment.html>


More information about the Kde-frameworks-devel mailing list