D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Withdrawing my approval, after realizing that this is missing the "enough free space at destination" check.
  Imagine a 5GB partition with a 4GB file on it. You want to copy another version of that 4GB file onto it. Old implementation: it works. New implementation: we start copying 1GB into a .part file, then it fails (out of space), and then IIUC we finally do the right thing and overwrite the file. Right? So it ends up working, but it's much slower than it should behave. This could be improved with a free space check, right?

INLINE COMMENTS

> filecopyjob.cpp:479
> +    if (job == d->m_copyJob) {
> +        d->m_bFileWriteInProgress = false;
> +    }

"file write" sounds like putJob, which isn't what this is about.

I guess this should be called d->m_bFileCopyInProgress instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio, ngraham
Cc: kde-frameworks-devel, ngraham, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190306/aac35b42/attachment.html>