D19299: Make it compile without foreach

[Laurent Montel]

mlaurent added a comment.


  for faceicontest it's phabricator which doesn"t like no UTF8 file
  I converted to utf8 with iconv but it still don't like it...
  
  {code}
  @@ -1,5 +1,5 @@
   /*
  
  - *  Copyright (C) 2014 Nicol341s Alvarez <nicolas.alvarez at gmail.com>
  
  + *  Copyright (C) 2014 Nicolás Alvarez <nicolas.alvarez at gmail.com>
  
    -
  - This library is free software; you can redistribute it and/or
  - modify it under the terms of the GNU Library General Public
  
  @@ -38,8 +38,8 @@ FaceIconTest::FaceIconTest()
  
    listWidget = new QListWidget(this);
    layout->addWidget(listWidget);
     
  
  - QList<KUser> users = KUser::allUsers();
  - Q_FOREACH (const KUser &u, users) {
  
  +    const QList<KUser> users = KUser::allUsers();
  +    for (const KUser &u : users) {
  
    QPixmap pixmap(u.faceIconPath());
    if (pixmap.isNull()) {
        pixmap = QPixmap(QSize(48, 48));
  
  {code}

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19299

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190303/445d436a/attachment.html>