D19170: Fix crash while moving files

David Faure noreply at phabricator.kde.org
Sat Mar 2 23:00:59 GMT 2019


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for testing the fix - and indeed the reverse case is useful to have too.

INLINE COMMENTS

> hallas wrote in filecopyjob.cpp:495
> Should we also set d->m_chmodJob to nullptr here, just like the m_putJob handling branch?

Right, probably a good idea, just in case.

> hallas wrote in filecopyjob.cpp:500
> Should we also set d->m_delJob to nullptr here, just like the m_putJob handling branch?

same

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: cfeck, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190302/26a9e27c/attachment.html>


More information about the Kde-frameworks-devel mailing list