D19318: compile without foreach

David Faure noreply at phabricator.kde.org
Sat Mar 2 22:54:43 GMT 2019


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kidletime.cpp:253
>  
>      if (associations.values().contains(msec)) {
> +        const auto listKeys = associations.keys(msec);

Urgh, how horrible and slow. But pre-existing, unrelated to your change.

REPOSITORY
  R274 KIdleTime

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190302/88f401b5/attachment.html>


More information about the Kde-frameworks-devel mailing list