D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Fri Mar 1 14:31:12 GMT 2019
kossebau updated this revision to Diff 52901.
kossebau added a comment.
Changes:
- clip when drawing the text document, so our "page" margins stay clean
- for that reuse vars some more
Somehow the old custom margins look nicer to me, so I kept the logic in the
code.
Seems QTextDocument draws the text with a bit more line-spacing, but not
sure if additional code to influence that is worth it.
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19432?vs=52899&id=52901
BRANCH
addsyntaxhighlighttotextpreview
REVISION DETAIL
https://phabricator.kde.org/D19432
AFFECTED FILES
CMakeLists.txt
thumbnail/CMakeLists.txt
thumbnail/textcreator.cpp
thumbnail/textcreator.h
To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190301/c1775e50/attachment.html>
More information about the Kde-frameworks-devel
mailing list