D18826: Rewrite the taglib extractor to use the generic PropertyMap interface
Alexander Stippich
noreply at phabricator.kde.org
Fri Mar 1 10:35:42 GMT 2019
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in taglibextractor.cpp:208
> Can you also use the same style as above, i.e. `const auto` and `for( : )`?
Oh, damn copy&paste
> smithjd wrote in taglibextractor.cpp:195
> lstASF = asfTags->attribute("WM/Writer");
> ...
>
> The existing code does this.
I wanted to avoid the extra querying, but apparently I already did the same for other special cases, so I did as you suggested
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18826
To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190301/8bc4e5bc/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list