D19437: [knewstuff] Remove qt5.13 deprecated method

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> installation.cpp:575
> +    connect(ret, static_cast<void(QProcess::*)(int, QProcess::ExitStatus)>(&QProcess::finished), this, [this, command](int exitcode){
>          if (exitcode) {
>              qCCritical(KNEWSTUFFCORE) << "Command '" << command << "' failed with code" << exitcode;

This should test the exit status too. I think that's the whole point of this change in Qt?

I guess the best way is

  if (status == crashed) 
     qCCritical "we crashed on the moon, good luck telling the families"
  else if (exitcode)
    ...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19437

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190301/9929e15e/attachment-0001.html>