D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[Christoph Cullmann]

cullmann added a comment.


  I think I misunderstood the feature, sorry.
  
  I did now try the patch again (it didn't apply perfectly, but that was just a few lines of code to be moved in the katedocument.cpp patch. I tend to agree that until we have perhaps some proper config for that in syntax files, some presets and the ability for users to add own presets make sense.
  
  On can still later introduce some "syntax defined" enum value to query stuff from the syntax defintions.
  
  What I would change is the placement of the SetOfCharsToEncloseSelection enum, I think it is only needed in the dialog, or? I got partly confused by that as I thought it would be used to store the settings, but the settings are just stored as stringlist and the enum is only to make the UI aware of the presets, or?

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, LeGast00n, domson, michaelh, bruns, demsking, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190630/fbc3050c/attachment.html>