D22107: Add MediaTransport API
David Rosca
noreply at phabricator.kde.org
Fri Jun 28 09:29:13 BST 2019
drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mweichselbaumer wrote in tpendingcall.h:45
> Actually, my intention was to provide a type-safe way to obtain return values from PendingCall and to express explicitly, what the corresponding method returns in API header.
> As a client you can make use of "auto".
>
> Consider:
>
> auto *fd = transport->tryAcquire(); // Method declaration will define return type.
> auto ret1 = fd->valueAt<0>();
> auto ret2 = fd->valueAt<1>();
> auto ret3 = fd->valueAt<2>();
>
> Thus, return type (of PendingCall) is expressed in API header and clients do not need to express the return types themselves.
Alright, that makes sense.
With KF6 we can convert all PendingCalls to this form. It would be a good idea to add `TODO: KF6` somewhere to not forget it.
REPOSITORY
R269 BluezQt
BRANCH
mediatransport
REVISION DETAIL
https://phabricator.kde.org/D22107
To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190628/de3ffd42/attachment.html>
More information about the Kde-frameworks-devel
mailing list