D22102: Implement apply-on-double-click for all grid view KCM delegates

Nathaniel Graham noreply at phabricator.kde.org
Wed Jun 26 12:23:41 BST 2019


ngraham created this revision.
ngraham added reviewers: Plasma, VDG, mart, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is a better-implemented alternative to D18571 <https://phabricator.kde.org/D18571>.
  
  The colors KCM currently has a feature whereby you can double-click on the delegates
  to selct and apply a color scheme. I find myself using it all the time and it's very
  convenient. This patch implements it universally for all `GridViewKCM` components.
  
  FEATURE: 398303
  FIXED-IN: 5.60

TEST PLAN
  Double-click on the items in the Icons, Plasma Theme, Cursors, Splash Screen, and 
  Look-And-Feel KCMs. The new setting is instantly applied. For the LNF KCM, this
  also means the "Use desktop layout from theme" checkbox gets applied instantly as
  well if the user had checked it. This doesn't seem to be a problem because it's
  unchecked by default, and if the user checked it, that's a sign they wanted to do it.

REPOSITORY
  R296 KDeclarative

BRANCH
  apply-on-double-click (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22102

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #plasma, #vdg, mart, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190626/fd71ba3a/attachment.html>


More information about the Kde-frameworks-devel mailing list