D22093: Don't show progress window for jobs that don't report progress
Nicolas Fella
noreply at phabricator.kde.org
Tue Jun 25 17:44:45 BST 2019
nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Most plugins (all but the youtube one) don't report any progress in their jobs. This results in a window with an empty progress bar flashing for a few seconds. Let's hide the window by default and allow plugins to enable it.
TEST PLAN
Shared stuff via imgur/telegram. No window appears. Share stuff via KDE Connect. Window disappears after selecting a device
REPOSITORY
R495 Purpose Library
BRANCH
noprogress
REVISION DETAIL
https://phabricator.kde.org/D22093
AFFECTED FILES
src/job.cpp
src/job.h
src/plugins/youtube/youtubejobcomposite.cpp
src/quick/AlternativesView.qml
src/quick/RunningJob.qml
src/widgets/JobDialog.qml
src/widgets/menu.cpp
To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190625/e14affb8/attachment.html>
More information about the Kde-frameworks-devel
mailing list