D22083: introduce concept of header and footer for kpageview

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kpageview.cpp:458
> +
> +    if (d->pageHeader == header) {
> +        return;

This check is duplicated.

> kpageview.cpp:476
> +    }
> +    
> +}

Please remove this empty line.

> kpageview.h:163
> +    /**
> +     * Set a widget as the header for this Page view
> +     * It will replace the standard page title

Does this transfer ownership of the widget? If yes, is ownership transferred back for any previously set widget? Or is it even automatically deleted? It needs to be clarified in the docs.

> kpageview_p.h:81
>  
> +    QPointer <QWidget> pageHeader;
> +    QPointer <QWidget> pageFooter;

No space before `<`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg
Cc: cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190625/08110f09/attachment.html>