D22055: Improve Job Dialog buttons' icons and text
Nathaniel Graham
noreply at phabricator.kde.org
Sun Jun 23 19:15:06 BST 2019
ngraham created this revision.
ngraham added reviewers: nicolasfella, apol, GB_2, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The buttons were on the wrong side of the window, lacked icons, and the affirmative
button said "run" which didn't match the verb used in the dialog's title "send".
This patch corrects those issues.
TEST PLAN
F6928593: Screenshot_20190623_201202.png <https://phabricator.kde.org/F6928593>
REPOSITORY
R495 Purpose Library
BRANCH
better-job-dialog-buttons (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22055
AFFECTED FILES
src/widgets/JobDialog.qml
To: ngraham, nicolasfella, apol, GB_2, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190623/93e989dd/attachment.html>
More information about the Kde-frameworks-devel
mailing list