D20193: Expose locked keystates on KModifierKeyInfo when on wayland

Alexey Min noreply at phabricator.kde.org
Sat Jun 22 23:49:13 BST 2019


alexeymin added inline comments.

INLINE COMMENTS

> dfaure wrote in kmodifierkeyinfoprovider.cpp:90
> Calling this an "abuse" is very arguable, see https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
> I'm not aware of a KF5 policy about this, so it's fine as is.

There is a Qt recommendation though: https://wiki.qt.io/Coding_Conventions#auto_Keyword

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190622/d1799ed5/attachment.html>


More information about the Kde-frameworks-devel mailing list