D21989: Don't show error message if sharing is cancelled by the user
    Kai Uwe Broulik 
    noreply at phabricator.kde.org
       
    Sat Jun 22 11:58:52 BST 2019
    
    
  
broulik added inline comments.
INLINE COMMENTS
> sharefileitemaction.cpp:55
> +        // error == 0 means no error, error == 1 means cancelled by the user
> +        if (error <= 1) {
>              if (output.contains(QLatin1String("url")))
If possible use `KIO::ERR_USER_CANCELED`, otherwise don't bother, comment's fine
REPOSITORY
  R495 Purpose Library
REVISION DETAIL
  https://phabricator.kde.org/D21989
To: nicolasfella, apol, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190622/308a05e5/attachment.html>
    
    
More information about the Kde-frameworks-devel
mailing list