D21907: Show feedback inline when creating new files or folders

Méven Car noreply at phabricator.kde.org
Sat Jun 22 09:55:54 BST 2019


meven added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:1099
> +            m_messageWidget->setMessageType(KMessageWidget::Information);
> +            m_messageWidget->animatedShow();
> +        }

Shouldn't we disable the ok button here ?

> knewfilemenu.cpp:1109
> +        m_messageWidget->setMessageType(KMessageWidget::Error);
> +        m_messageWidget->animatedShow();
> +    }

Shouldn't we disable the ok button here too ?

> knewfilemenu.cpp:1114
> +        m_messageWidget->setMessageType(KMessageWidget::Error);
> +        m_messageWidget->animatedShow();
> +    }

Same here

> knewfilemenu.cpp:1122
> +        m_messageWidget->setMessageType(KMessageWidget::Warning);
> +        m_messageWidget->animatedShow();
> +    }

Same here

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190622/aca764ef/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list