D21955: [copyjob] Only set modification time if the kio-slave provided it

David Faure noreply at phabricator.kde.org
Fri Jun 21 13:05:42 BST 2019


dfaure added a comment.


  Ah sorry that was in your commit log.
  
    info.mtime = QDateTime::fromMSecsSinceEpoch(1000 * entry.numberValue(KIO::UDSEntry::UDS_MODIFICATION_TIME, -1), Qt::UTC);
  
  should be changed to:
  
    const auto timeVal = entry.numberValue(KIO::UDSEntry::UDS_MODIFICATION_TIME, -1);
    if (timeVal != -1) {
        info.mtime = QDateTime::fromMSecsSinceEpoch(1000 * timeVal, Qt::UTC);
    }

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21955

To: wbauer, #frameworks, bruns, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, #dolphin, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190621/a4641dd9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list